OnKeyPress Subroutine Executed Twice

[armsys]

Dialog>Dialog1
EndDialog>Dialog1
AddDialogHandler>Dialog1,MSComboBox2,OnKeyPress,DoKeyPress
Show>Dialog1,r

Debugger tests show AddDialogHandler always runs twice when an item is selected from MSComboBox2 by pressing ENTER. But why?

[Marcus Tettmar]

Not in my case. I am only seeing one execution of the OnKeyPress subroutine when pressing Enter.

The following code increments a counter which appears in the dialog's title bar. If you press Enter while on the combo box you will see the counter is incremented by one only:

Code: Select all

Let>x=0

AddDialogHandler>Dialog1,MSComboBox1,OnKeyPress,DoKeyPress
Show>Dialog1,r

SRT>DoKeyPress
  Let>x=x+1
  SetDialogProperty>Dialog1,,Caption,x
END>DoKeyPress

[armsys]

Marcus,
Thanks for taking time to explore the OnKeyPress subroutine issue.
In my case, it still repeats twice.
In my case, it occurs in the 2nd combobox.
The contents in the 2nd combox are constructed on the fly depending on the combobox1 selection, ie, DoChgList as shown below.
I have to use variable DoKeyPressRun to stop SRT>DoKeyPress from running twice. Here the DoKeyPress simulates pressing &Ok button.
The debugger shows, after completing the DoKeyPress, the execution pointer(_LINE_NUM) is returned back to **BREAKPOINT** again.

Let>DoKeyPressRun=1
Dialog>Dialog1
EndDialog>Dialog1

AddDialogHandler>Dialog1,MSComboBox1,OnSelect,DoChgList
AddDialogHandler>Dialog1,MSComboBox2,OnKeyPress,DoKeyPress

SRT>DoKeyPress
**BREAKPOINT**
IF>DoKeyPressRun=1
If>{(%DoKeyPress_KEY%=13) or (%DoKeyPress_KEY%=32)}
Let>ModalResult=1
Press ALT
Send>o
Release ALT
Add>DoKeyPressRun,1
Endif
Endif
End>DoKeyPress

[Marcus Tettmar]

Can you send me your dialog code.

[armsys]

Marcus,
After submitting my last post, I realize my code does press keys in the DoKeyPress:
Press CTRL
Send>o
Release CTRL

That may explain why MS triggers SRT>DoKeyPress again.
If my thinking is correct, then the itching question remains: how to stop DoKeyPress from running twice.

[Marcus Tettmar]

You're sending CTRL-O. Where do you want to send that? If you are not using SetFocus then it will land on the combo box. In which case then of course it will trigger the OnKeyPress.

If you don't want it to land on the combo box then insert a SetFocus to make it go someplace else intended and then the OnKeyPress won't fire.

If you DO want it to land on the combo box then set some kind of flag in your OnKeyPress subroutine so that the code cannot fire until you're done.

[armsys]

Marcus,
Your idea is very helpful.
2 more questions:
Q1: I add SetDialogObjectFocus so that the focus shifts from combox2 to the Ok button. Still DoKeyPress is fired 2nd time.
SRT>DoKeyPress
**BREAKPOINT**
SetDialogObjectFocus>Dialog1,MSButton1
IF>DoKeyPressRun=1
If>{(%DoKeyPress_KEY%=13) or (%DoKeyPress_KEY%=32)}
Let>ModalResult=1
Press ALT
Send>o
Release ALT
Add>DoKeyPressRun,1
Endif
Endif
End>DoKeyPress

Q2
We have AddDialogHandler>Dialog1,MSComboBox2,OnKeyPress,DoKeyPress.
What if we wish to disable DoKeyPress inside the DoKeyPress subroutine?
That's in Macro Scheduler, we can enable to OnKeyPress event subroutine. It doesn't seem unable to disable it during the runtime.

[armsys]

After submitting my last post, I realize my code does press keys in the DoKeyPress:
Press CTRL
Send>o
Release CTRL

It contains typos, alas.
It should read:
Press ALT
Send>o
Release ALT

Its purpose is to simulate pressing the Ok button.
The whole picture is: when selecting an item in combobox2 by pressing ENTER, it's assumed the user accepts the selections from combox1 and combobox 2. Therefore, the Ok button is presssed programmatically.

[Marcus Tettmar]

Why do you want to send alt-o to an ok button you created and control? Seems a bit odd. Why not just do whatever the OK button triggers. There's no need to send keystrokes to your own dialog!

You can't disable a handler at this time, but you could use a flag as already suggested. Check the value of the flag at the start of the routine and only proceed if it is set/unset.