Carriage Returns sent after variables (version 9.2.01)

[[email protected]]

We're having trouble with carriage returns occurring after we post any kind of variable.

We are pulling variables out of an excel sheet and when we try and paste them (in a message modal, or to create a directory using the variables we've collected) it always adds a carriage return after each variable sent (see an example of our data below)

Here is the code where we paste the data:

Code: Select all

SRT>FolderCreator

SetFocus>Microsoft Excel - *

DDEREQUEST>Excel,%granfilepath%:data2,R1C3,piececount,10

wait>1

MessageModal> Press Okay to Continue on to Make %piececount% Folders


If>%piececount%>0
	
	let>x=0
	repeat>x
	let>x=x+1

	DDEREQUEST>Excel,%granfilepath%:Data2,R%x%C1,donkey,10
	SetFocus>jobtest*

	CreateDir>t:\%year%\GRANITE Jobs - %year%\%gran_jobnum% - %gran_jobname%\%gran_jobnum% - %donkey%
	MessageModal>Directory t:\%year%\GRANITE Jobs - %year%\%gran_jobnum% - %gran_jobname%\%gran_jobnum% - %donkey% Made!

	until>x,%piececount%

else
	messagemodal>All Done
	goto>end
endif

end>FolderCreator

Here is what happens:

Code: Select all

t:\2010

\GRANITE Jobs - 2010

\9999G

 - test_test

\9999G

 -  Kitchen 1 of 3

Code: Select all

[adroege]

Something like this will strip the CRLF characters

Code: Select all

StringReplace>source,%CRLF%,,strNewString

[[email protected]]

Hey Adroege, thanks for getting back to me. Ur solution will work for sending a string, but our problem with carriage returns that follow sent variables runs deeper.

In one part of our macro we are sending variables to our autocad program (DraftSight, which is free) and when we pull a variable from our excel sheet and then send it to the cad program, it ends up also sending a carriage return immediately afterwards, which messes up the syntax of the DraftSight command (i.e. when we need to send an X coordinate, followed by a comma, followed by a Y coordinate and then press ENTER).

So when the X coordinate is sent, a carriage return is immediately sent, ending the command prematurely in autocad and then sending a comma and a 2nd variable which the cad program doesn't know what to do with because its out of context.

Is it a global setting somewhere in MacroScheduler that a carriage return is sent after each variable we send, paste, DDEPoke, etc?


Thanks for your help!

-Paul

Code: Select all

StringReplace>source,%CRLF%,,strNewString

[/quote]

[JRL]

Is it a global setting somewhere in MacroScheduler that a carriage return is sent after each variable we send, paste, DDEPoke, etc?

adroege is exactly correct. Every value you acquire from Excel using DDE will come with the carriage return and line feed characters (CRLF). That's because of the way Microsoft designed excel. Every Excel cell contains a carriage return/line feed. Since you don't want those characters included with the value of your variables, use the StringReplace> function to strip them out.

Since you don't show the code where you acquired the values for the variables "granfilepath", "year", "gran_jobnum", "gran_jobname" and "donkey", I assumed you also got those by DDE and so I included lines to strip %CRLF% from all of those variables in the rewrite of your sample code below.

Code: Select all

SRT>FolderCreator

SetFocus>Microsoft Excel - *

StringReplace>%granfilepath%,%CRLF%,,granfilepath
DDEREQUEST>Excel,%granfilepath%:data2,R1C3,piececount,10
StringReplace>%piececount%,%CRLF%,,piececount
wait>1

MessageModal> Press Okay to Continue on to Make %piececount% Folders


If>%piececount%>0
    StringReplace>%year%,%CRLF%,,year
    StringReplace>%gran_jobnum%,%CRLF%,,gran_jobnum
    StringReplace>%gran_jobname%,%CRLF%,,gran_jobname
    
    let>x=0
    repeat>x
    let>x=x+1

    DDEREQUEST>Excel,%granfilepath%:Data2,R%x%C1,donkey,10
    StringReplace>%donkey%,%CRLF%,,donkey
    SetFocus>jobtest*

    CreateDir>t:\%year%\GRANITE Jobs - %year%\%gran_jobnum% - %gran_jobname%\%gran_jobnum% - %donkey%
    MessageModal>Directory t:\%year%\GRANITE Jobs - %year%\%gran_jobnum% - %gran_jobname%\%gran_jobnum% - %donkey% Made!

    until>x,%piececount%

else
    messagemodal>All Done
    goto>end
endif

end>FolderCreator

[jpuziano]

Is it a global setting somewhere in MacroScheduler that a carriage return is sent after each variable we send, paste, DDEPoke, etc?

I'd say no. Can you possibly post the code you're using to send the values?

In one part of our macro we are sending variables to our autocad program (DraftSight, which is free) and when we pull a variable from our excel sheet and then send it to the cad program, it ends up also sending a carriage return immediately afterwards, which messes up the syntax of the DraftSight command (i.e. when we need to send an X coordinate, followed by a comma, followed by a Y coordinate and then press ENTER).

however you said...

Ur solution will work for sending a string

so... why not first build a string containing your X coordinate, followed by a comma, followed by a Y coordinate and then just send the string?

i.e.

Let>myString=10,25
Send>myString

or if you need the Enter to be sent along as well...

Let>myString=10,25%CR%
Send>myString

[Marcus Tettmar]

JRL is correct. When you use DDE to get data from Excel you always end up with CRLF at the end of the data. No idea why. Blame Microsoft

So as a number of people have suggested use StringReplace after your DDERequest lines to remove the CRLFs.

DDE is deprecated anyway, though amazingly Excel still supports it. Might not for much longer. I would advise using DBQuery or VBScript or the new XL functions instead.