Dialog not showing when executed from another script file

[Richard]

I use the Macro command to execute another script file. This other script file contains a dialog. The problem is that this dialog won't show. I don't know if I'm doing something wrong, or if this is a bug. I have simplyfied my code to reproduce the problem here.

The first macro file called MyDialog.scp contains a simple standard dialog with a dummy button. It has the following code:

Code: Select all

Dialog>Dialog1
object Dialog1: TForm
  Left = 2167
  Top = 96
  HelpContext = 5000
  BorderIcons = [biSystemMenu]
  Caption = 'CustomDialog'
  ClientHeight = 212
  ClientWidth = 431
  Color = clBtnFace
  Font.Charset = DEFAULT_CHARSET
  Font.Color = clWindowText
  Font.Height = -11
  Font.Name = 'MS Sans Serif'
  Font.Style = []
  OldCreateOrder = True
  ShowHint = True
  OnTaskBar = False
  PixelsPerInch = 96
  TextHeight = 13
  object MSButton1: tMSButton
    Left = 155
    Top = 81
    Width = 75
    Height = 25
    Caption = 'MSButton1'
    DoubleBuffered = True
    ParentDoubleBuffered = False
    TabOrder = 8
    DoBrowse = False
    BrowseStyle = fbOpen
  end
end
EndDialog>Dialog1

Show>Dialog1,result
let>MACRO_RESULT=1

The second Macro file, called MyTestMacro.scp, contains this code:

Code: Select all

Macro>%SCRIPT_DIR%\MyDialog.scp
MessageModal>MACRO_RESULT=%MACRO_RESULT%

When I execute the MyDialog file, the dialog shows up. When I execute the MyTestMacro file, it immediately shows the messagebox with the text MACRO_RESULT=1. But the dialog in the MyDialog file never shows.

Can anyone explain what's going wrong?

kind regards,
Richard

[JRL]

Hi Richard,

I can't explain the problem but I can confirm it.

After seeing your post and copying your scripts and then witnessing that the dialog does not display, I rewrote your two scripts thinking there might be something unusual in your dialog. I got the same result. Then I went back to the pre version 12 dialog form and all works as planned. Something seems to be broken with calling a version 12 dialog using the Macro> function.

Here's a pre version 12 dialog in a script similar to your first script, that will work... or at least worked for me.

Later,
Dick

Code: Select all

Dialog>Dialog1
   Caption=Dialog1
   Width=445
   Height=250
   Top=289
   Left=291
   Button=msButton1,182,153,75,25,0
EndDialog>Dialog1


Show>Dialog1,result
let>MACRO_RESULT=1

[Richard]

Thanks, however, the real dialog i'm using is a lot more complex and uses lots of DialogHandlers. I've found a kind of work around by including the file with the dialog functionality in the main macro file.
I'm not too keen on using the Include>... thing, because it sometimes causes problems with the debugger, but it will have to do.

Anyway, thanks for the quick response and I hope that perhaps in a next version the problem will be solved.

kind regards,
Richard.

[JRL]

I know the Include / debugger issue you're refering to. I believe it was resolved with version 12.

If you don't want to use Include and you can't go back to pre 12 dialogs you might also try using Run> or Execute>

Run>msched.exe %SCRIPT_DIR%\MyDialog.scp

Or just

Exe>%SCRIPT_DIR%\MyDialog.scp

In either case you can loop to wait for a response from the dialog script before continuing the calling script to cause behavior similar to the Macro> function.

Label>WaitingForDialogScriptToComplete
If>%MACRO_RESULT%1
Wait>0.01
Goto>WaitingForDialogScriptToComplete
EndIf

[Richard]

That is an interesting alternative. I might try that. It does show the dialog that way. However, it would be a bit more difficult to pass a result variable back to the calling script. You can't use the MACRO_RESULT variable, and using an exit code only works for compiled scripts, but I could probably use a registry setting or write to a file.

Thanks for the help.

kind regards,
Richard

[JRL]

You can't use the MACRO_RESULT variable

Oops. You are correct, the code snippet I submitted will not work. Sorry for the misinformation. You are also correct that you could use the registry (which is a file) or write to a file of your own. You could also pass variable info via the clipboard.

Anyway, thanks for the quick response and I hope that perhaps in a next version the problem will be solved.

I agree, hopefully it will be an easy fix.

[Marcus Tettmar]

Just to say this has been noted, replicated and is straight on the work list.