Condition ignored

[dagdag]

Hi , I have written this code so it closes Excel than does something else.
It worked when I had Excel open but did not when I had no excel file open. Please help


ifWindowOpen>Microsoft Excel*,closeex
label>closeex
CloseWindow>Microsoft Excel*
goto>closecpms
label>closecpms
ifWindowOpen>CPMS*,endline
wait> 30
ExecuteFile>C:\CPMSWin2\CPMSUpdater.exe
label>endline

[Marcus Tettmar]

This code will try to close Excel whether or not Excel is already open.

Your logic says if excel is open goto the closeex label. It it is not open go to the next line ... which IS the closeex label! So you ALWAYS go to the closeex label!

You might as well remove the IfWindowOpen line as it makes no difference.

You also have a line that says Goto>closecpms yet Label>closecpms is on the very next line ... not sure what the point of that is.

You also have an erroneous space in the Wait command.

I expect you might be intending to do something like:


ifWindowOpen>Microsoft Excel*,closeex
goto>closecpms
label>closeex
CloseWindow>Microsoft Excel*
label>closecpms
ifWindowOpen>CPMS*,endline
wait>30
ExecuteFile>C:\CPMSWin2\CPMSUpdater.exe
label>endline


If you have 7.3 or later you can simplify this logic:


IfWindowOpen>Microsoft Excel*
CloseWindow>Microsoft Excel*
Endif

IfWindowOpen>CMPS*
//Do nothing
ELSE
wait>30
ExecuteFile>C:\CPMSWin2\CPMSUpdater.exe
ENDIF

[dagdag]

Thanks it works !
AD

Hi , I have written this code so it closes Excel than does something else.
It worked when I had Excel open but did not when I had no excel file open. Please help


ifWindowOpen>Microsoft Excel*,closeex
label>closeex
CloseWindow>Microsoft Excel*
goto>closecpms
label>closecpms
ifWindowOpen>CPMS*,endline
wait> 30
ExecuteFile>C:\CPMSWin2\CPMSUpdater.exe
label>endline