Some suggestions and bug report

observer · Post by **observer** » Mon Aug 24, 2009 2:30 am

Hi!
There are my suggestions and my bug report.
Bug#1(I am not sure)
Run this code and check the last symbol in the text file. Is that normal?

Code: Select all

// Set your values for Folder and OutputFile parameters and run
Let>Folder=C:
Let>OutputFile=C:\FileList.txt
//
Let>GFL_TYPE=0
GetFileList>%Folder%\*.*,strFileList,%CRLF%
Let>WLN_NOCRLF=1
WriteLn>%OutputFile%,nWLNRes,%strFileList%
ExecuteFile>%OutputFile%,

Bug#2 (Dialog Designer issues)
a. There was lost a possibility to set Dialog main window properties (double-click and F11 are not responding)
b. Help file defines "ResetDialogAction ... updates the values of Edits, Memos, Checkboxes, Listboxes, Comboboxes, RadioGroups and Progressbars." But RadioGroups are not updating. Also it would be useful to update Images.
c. Dialog window are created much slower (than in MS ver.10) if it has a great number of options. Also you can get some artefacts.
Try for example this code (you should run Dialog Designer, not the script code)

Code: Select all

Dialog>Dialog1
   Caption=RenamePicture
   Width=928
   Height=585
   Top=CENTER
   Left=CENTER
   Max=1
   Min=1
   Close=1
   Resize=1
   Label=Mark,14,2,true
   Label=Mark,196,2,true
   Label=Mark,348,2,true
   Label=Mark,500,2,true
   Label=Mark,652,2,true
   Label=Mark,804,2,true
   CheckBox=msCheckBox1,,24,20,97,False
   CheckBox=msCheckBox2,,24,52,97,False
   CheckBox=msCheckBox3,,24,84,97,False
   CheckBox=msCheckBox4,,24,116,97,False
   CheckBox=msCheckBox5,,24,148,97,False
   CheckBox=msCheckBox6,,24,180,97,False
   CheckBox=msCheckBox7,,24,212,97,False
   CheckBox=msCheckBox8,,24,244,97,False
   CheckBox=msCheckBox9,,24,276,97,False
   CheckBox=msCheckBox10,,24,308,97,False
   CheckBox=msCheckBox11,,24,340,97,False
   CheckBox=msCheckBox12,,24,372,97,False
   CheckBox=msCheckBox13,,24,404,97,False
   CheckBox=msCheckBox14,,24,436,97,False
   CheckBox=msCheckBox15,,206,20,97,False
   CheckBox=msCheckBox16,,206,52,97,False
   CheckBox=msCheckBox17,,206,84,97,False
   CheckBox=msCheckBox18,,206,116,97,False
   CheckBox=msCheckBox19,,206,148,97,False
   CheckBox=msCheckBox20,,206,180,97,False
   CheckBox=msCheckBox21,,206,212,97,False
   CheckBox=msCheckBox22,,206,244,97,False
   CheckBox=msCheckBox23,,206,276,97,False
   CheckBox=msCheckBox24,,206,308,97,False
   CheckBox=msCheckBox25,,206,340,97,False
   CheckBox=msCheckBox26,,206,372,97,False
   CheckBox=msCheckBox27,,206,404,97,False
   CheckBox=msCheckBox28,,206,436,97,False
   CheckBox=msCheckBox29,,358,20,97,False
   CheckBox=msCheckBox30,,358,52,97,False
   CheckBox=msCheckBox31,,358,84,97,False
   CheckBox=msCheckBox32,,358,116,97,False
   CheckBox=msCheckBox33,,358,148,97,False
   CheckBox=msCheckBox34,,358,180,97,False
   CheckBox=msCheckBox35,,358,212,97,False
   CheckBox=msCheckBox36,,358,244,97,False
   CheckBox=msCheckBox37,,358,276,97,False
   CheckBox=msCheckBox38,,358,308,97,False
   CheckBox=msCheckBox39,,358,340,97,False
   CheckBox=msCheckBox40,,358,372,97,False
   CheckBox=msCheckBox41,,358,404,97,False
   CheckBox=msCheckBox42,,358,436,97,False
   CheckBox=msCheckBox43,,510,20,97,False
   CheckBox=msCheckBox44,,510,52,97,False
   CheckBox=msCheckBox45,,510,84,97,False
   CheckBox=msCheckBox46,,510,116,97,False
   CheckBox=msCheckBox47,,510,148,97,False
   CheckBox=msCheckBox48,,510,180,97,False
   CheckBox=msCheckBox49,,510,212,97,False
   CheckBox=msCheckBox50,,510,244,97,False
   CheckBox=msCheckBox51,,510,276,97,False
   CheckBox=msCheckBox52,,510,308,97,False
   CheckBox=msCheckBox53,,510,340,97,False
   CheckBox=msCheckBox54,,510,372,97,False
   CheckBox=msCheckBox55,,510,404,97,False
   CheckBox=msCheckBox56,,510,436,97,False
   CheckBox=msCheckBox57,,662,20,97,False
   CheckBox=msCheckBox58,,662,52,97,False
   CheckBox=msCheckBox59,,662,84,97,False
   CheckBox=msCheckBox60,,662,116,97,False
   CheckBox=msCheckBox61,,662,148,97,False
   CheckBox=msCheckBox62,,662,180,97,False
   CheckBox=msCheckBox63,,662,212,97,False
   CheckBox=msCheckBox64,,662,244,97,False
   CheckBox=msCheckBox65,,662,276,97,False
   CheckBox=msCheckBox66,,662,308,97,False
   CheckBox=msCheckBox67,,662,340,97,False
   CheckBox=msCheckBox68,,662,372,97,False
   CheckBox=msCheckBox69,,662,404,97,False
   CheckBox=msCheckBox70,,662,436,97,False
   CheckBox=msCheckBox71,,814,20,97,False
   CheckBox=msCheckBox72,,814,52,97,False
   CheckBox=msCheckBox73,,814,84,97,False
   CheckBox=msCheckBox74,,814,116,97,False
   CheckBox=msCheckBox75,,814,148,97,False
   CheckBox=msCheckBox76,,814,180,97,False
   CheckBox=msCheckBox77,,814,212,97,False
   CheckBox=msCheckBox78,,814,244,97,False
   CheckBox=msCheckBox79,,814,276,97,False
   CheckBox=msCheckBox80,,814,308,97,False
   CheckBox=msCheckBox81,,814,340,97,False
   CheckBox=msCheckBox82,,814,372,97,False
   CheckBox=msCheckBox83,,814,404,97,False
   CheckBox=msCheckBox84,,814,436,97,False
   Edit=Edit1,92,16,41,
   Edit=Edit2,92,48,41,
   Edit=Edit3,92,80,41,
   Edit=Edit4,92,112,41,
   Edit=Edit5,92,144,41,
   Edit=Edit6,92,176,41,
   Edit=Edit7,92,208,41,
   Edit=Edit8,92,240,41,
   Edit=Edit9,92,272,41,
   Edit=Edit10,92,304,41,
   Edit=Edit11,92,336,41,
   Edit=Edit12,92,368,41,
   Edit=Edit13,92,400,41,
   Edit=Edit14,92,432,41,
   Edit=Edit15,244,16,41,
   Edit=Edit16,244,48,41,
   Edit=Edit17,244,80,41,
   Edit=Edit18,244,112,41,
   Edit=Edit19,244,144,41,
   Edit=Edit20,244,176,41,
   Edit=Edit21,244,208,41,
   Edit=Edit22,244,240,41,
   Edit=Edit23,244,272,41,
   Edit=Edit24,244,304,41,
   Edit=Edit25,244,336,41,
   Edit=Edit26,244,368,41,
   Edit=Edit27,244,400,41,
   Edit=Edit28,244,432,41,
   Edit=Edit29,396,16,41,
   Edit=Edit30,396,48,41,
   Edit=Edit31,396,80,41,
   Edit=Edit32,396,112,41,
   Edit=Edit33,396,144,41,
   Edit=Edit34,396,176,41,
   Edit=Edit35,396,208,41,
   Edit=Edit36,396,240,41,
   Edit=Edit37,396,272,41,
   Edit=Edit38,396,304,41,
   Edit=Edit39,396,336,41,
   Edit=Edit40,396,368,41,
   Edit=Edit41,396,400,41,
   Edit=Edit42,396,432,41,
   Edit=Edit43,548,16,41,
   Edit=Edit44,548,48,41,
   Edit=Edit45,548,80,41,
   Edit=Edit46,548,112,41,
   Edit=Edit47,548,144,41,
   Edit=Edit48,548,176,41,
   Edit=Edit49,548,208,41,
   Edit=Edit50,548,240,41,
   Edit=Edit51,548,272,41,
   Edit=Edit52,548,304,41,
   Edit=Edit53,548,336,41,
   Edit=Edit54,548,368,41,
   Edit=Edit55,548,400,41,
   Edit=Edit56,548,432,41,
   Edit=Edit57,700,16,41,
   Edit=Edit58,700,48,41,
   Edit=Edit59,700,80,41,
   Edit=Edit60,700,112,41,
   Edit=Edit61,700,144,41,
   Edit=Edit62,700,176,41,
   Edit=Edit63,700,208,41,
   Edit=Edit64,700,240,41,
   Edit=Edit65,700,272,41,
   Edit=Edit66,700,304,41,
   Edit=Edit67,700,336,41,
   Edit=Edit68,700,368,41,
   Edit=Edit69,700,400,41,
   Edit=Edit70,700,432,41,
   Edit=Edit71,852,16,41,
   Edit=Edit72,852,48,41,
   Edit=Edit73,852,80,41,
   Edit=Edit74,852,112,41,
   Edit=Edit75,852,144,41,
   Edit=Edit76,852,176,41,
   Edit=Edit77,852,208,41,
   Edit=Edit78,852,240,41,
   Edit=Edit79,852,272,41,
   Edit=Edit80,852,304,41,
   Edit=Edit81,852,336,41,
   Edit=Edit82,852,368,41,
   Edit=Edit83,852,400,41,
   Edit=Edit84,852,432,41,
   Image=Picture_1,44,20,65,33,Image1,0
   Image=Picture_2,44,52,65,33,Image2,0
   Image=Picture_3,44,84,65,33,Image3,0
   Image=Picture_4,44,116,65,33,Image4,0
   Image=Picture_5,44,148,65,33,Image5,0
   Image=Picture_6,44,180,65,33,Image6,0
   Image=Picture_7,44,212,65,33,Image7,0
   Image=Picture_8,44,244,65,33,Image8,0
   Image=Picture_9,44,276,65,33,Image9,0
   Image=Picture_10,44,308,65,33,Image10,0
   Image=Picture_11,44,340,65,33,Image11,0
   Image=Picture_12,44,372,65,33,Image12,0
   Image=Picture_13,44,404,65,33,Image13,0
   Image=Picture_14,44,436,65,33,Image14,0
   Image=Picture_15,246,20,65,33,Image15,0
   Image=Picture_16,246,52,65,33,Image16,0
   Image=Picture_17,246,84,65,33,Image17,0
   Image=Picture_18,246,116,65,33,Image18,0
   Image=Picture_19,246,148,65,33,Image19,0
   Image=Picture_20,246,180,65,33,Image20,0
   Image=Picture_21,246,212,65,33,Image21,0
   Image=Picture_22,246,244,65,33,Image22,0
   Image=Picture_23,246,276,65,33,Image23,0
   Image=Picture_24,246,308,65,33,Image24,0
   Image=Picture_25,246,340,65,33,Image25,0
   Image=Picture_26,246,372,65,33,Image26,0
   Image=Picture_27,246,404,65,33,Image27,0
   Image=Picture_28,246,436,65,33,Image28,0
   Image=Picture_29,378,20,65,33,Image29,0
   Image=Picture_30,378,52,65,33,Image30,0
   Image=Picture_31,378,84,65,33,Image31,0
   Image=Picture_32,378,116,65,33,Image32,0
   Image=Picture_33,378,148,65,33,Image33,0
   Image=Picture_34,378,180,65,33,Image34,0
   Image=Picture_35,378,212,65,33,Image35,0
   Image=Picture_36,378,244,65,33,Image36,0
   Image=Picture_37,378,276,65,33,Image37,0
   Image=Picture_38,378,308,65,33,Image38,0
   Image=Picture_39,378,340,65,33,Image39,0
   Image=Picture_40,378,372,65,33,Image40,0
   Image=Picture_41,378,404,65,33,Image41,0
   Image=Picture_42,378,436,65,33,Image42,0
   Image=Picture_43,530,20,65,33,Image43,0
   Image=Picture_44,530,52,65,33,Image44,0
   Image=Picture_45,530,84,65,33,Image45,0
   Image=Picture_46,530,116,65,33,Image46,0
   Image=Picture_47,530,148,65,33,Image47,0
   Image=Picture_48,530,180,65,33,Image48,0
   Image=Picture_49,530,212,65,33,Image49,0
   Image=Picture_50,530,244,65,33,Image50,0
   Image=Picture_51,530,276,65,33,Image51,0
   Image=Picture_52,530,308,65,33,Image52,0
   Image=Picture_53,530,340,65,33,Image53,0
   Image=Picture_54,530,372,65,33,Image54,0
   Image=Picture_55,530,404,65,33,Image55,0
   Image=Picture_56,530,436,65,33,Image56,0
   Image=Picture_57,682,20,65,33,Image57,0
   Image=Picture_58,682,52,65,33,Image58,0
   Image=Picture_59,682,84,65,33,Image59,0
   Image=Picture_60,682,116,65,33,Image60,0
   Image=Picture_61,682,148,65,33,Image61,0
   Image=Picture_62,682,180,65,33,Image62,0
   Image=Picture_63,682,212,65,33,Image63,0
   Image=Picture_64,682,244,65,33,Image64,0
   Image=Picture_65,682,276,65,33,Image65,0
   Image=Picture_66,682,308,65,33,Image66,0
   Image=Picture_67,682,340,65,33,Image67,0
   Image=Picture_68,682,372,65,33,Image68,0
   Image=Picture_69,682,404,65,33,Image69,0
   Image=Picture_70,682,436,65,33,Image70,0
   Image=Picture_71,824,20,65,33,Image71,0
   Image=Picture_72,824,52,65,33,Image72,0
   Image=Picture_73,824,84,65,33,Image73,0
   Image=Picture_74,824,116,65,33,Image74,0
   Image=Picture_75,824,148,65,33,Image75,0
   Image=Picture_76,824,180,65,33,Image76,0
   Image=Picture_77,824,212,65,33,Image77,0
   Image=Picture_78,824,244,65,33,Image78,0
   Image=Picture_79,824,276,65,33,Image79,0
   Image=Picture_80,824,308,65,33,Image80,0
   Image=Picture_81,824,340,65,33,Image81,0
   Image=Picture_82,824,372,65,33,Image82,0
   Image=Picture_83,824,404,65,33,Image83,0
   Image=Picture_84,824,436,65,33,Image84,0
   Button=S T A R T,24,468,873,57,3
EndDialog>Dialog1

Suggestion#1
I don't like "Search Text" and "Replace Text" windows disappear after the process of searching/replacing was started. What if I need more than one search/replace? I have to click on search/replace button and set the parameters again. It's inconvenient.
Suggestion#2
It seems to me Search/Replace windows are too large. It would be more optimal to stretch them horizontally. So, you can see more text in edit fields. Something like this

... or this one

Suggestion#3
As I know there is no possibility to make Code Folding more accuracy (Code Folding performs incorrectly when TrueLabel and FalseLabel are used ) So, we can turn Code Folding off. But there is no possibility to turn off wrong selection (if you set cursor to "IF"-line, so appropriate If and Endif will be selected). This is not a great problem but it makes difficulties.
Also it would be much better to show full "IF"-line instead of three dots when collapse is used.

observer · Post by **observer** » Mon Aug 24, 2009 10:42 am

One more bug
There is no any text in confirm window. Run Editor and set "prompt on replace" checkbox to true in "Replace Text" window and run "Replace All".

Post by **Marcus Tettmar** » Mon Aug 24, 2009 10:54 am

Please could you post bugs/requests/whatever as separate posts. Otherwise it is easy to miss some, and hard to track them.

I don't get any strange characters with your first sample code. The output file has no unexpected characters at the end.

The example dialog loads in the dialog editor in about 2 seconds for me.

Here's some code showing how to reset radio buttons with ResetDialogAction:

Code: Select all

Dialog>Dialog3
   Caption=Dialog3
   Width=445
   Height=204
   Top=CENTER
   Left=CENTER
   Max=1
   Min=1
   Close=1
   Resize=1
   RadioGroup=msRadioGroup1,msRadioGroup1,48,8,185,105,One%CRLF%Two,-1
   Button=1,47,130,75,25,20
   Button=2,149,132,75,25,21
EndDialog>Dialog3

Show>Dialog3

Label>loop
  GetDialogAction>Dialog3,r
  If>r=20
    Let>Dialog3.msRadioGroup1.ItemIndex=0
    ResetDialogAction>Dialog3
  Endif
  If>r=21
    Let>Dialog3.msRadioGroup1.ItemIndex=1
    ResetDialogAction>Dialog3
  Endif
Goto>loop

I am aware of the issue with not being able to access dialog properties with double click or F11 or right click. This will be fixed.

Other suggestions noted.

In future though please send separate posts.

JRL · Post by **JRL** » Mon Aug 24, 2009 12:48 pm

observer wrote:check the last symbol in the text file. Is that normal?

mtettmar wrote:I don't get any strange characters with your first sample code. The output file has no unexpected characters at the end.

Running Macro Scheduler 11.1.13 on WinXP SP3. When I run the code posted by observer I get a trailing carriage return (ASCII 13). If I change the GetFileList> delimiter value to "~1~2~3~"

GetFileList>%Folder%\*.*,strFileList,~1~2~3~

I get "~1~2~3" at the end of the text string. It would appear that GetFileList> is removing the last character from the text string. Perhaps on the assumption that the delimiter was going to be a single character and there would always be a delimiter character appended to the end?

Since %CRLF% is two characters, GetFileList> is stripping off the %LF%. Try looking at the result file using a hex editor rather than Notpad.

observer · Post by **observer** » Mon Aug 24, 2009 1:51 pm

Hi!
JRL
Thank you very much.

mtettmar
I bring my apologies for the cumulative report. I will fix it next time.
As for Dialog Designer issue, so I had ran it under Windows XP Pro, Windows XP Pro x64 and on VMWare VirtualMachine under Windows XP Pro.
a. When I had ran it on VMWare VirtualMachine there was no problem.
b. There were some artefacts under Win XP Pro x64 but the speed of dialog window drawing is high.
c. I had got low speed (~12 sec) and also artefacts under Win XP Pro (32-bit).
There were no issues with MS ver.10
As for RadioGroup updating issue, so I was not found any advices in the help file to set a value for DialogName.RadioGroupName variable and I thought it does not equal to a number but to the word I'd set (DialogName.RadioGroupName=One/Two from your code example).